linux-kernel - Re: [PATCH] kernel: update callers of task_work_add() to use TWA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200810201227.GC3982@worktop.programming.kicks-ass.net>
Date:   Mon, 10 Aug 2020 22:12:27 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH] kernel: update callers of task_work_add() to use
 TWA_RESUME

On Mon, Aug 10, 2020 at 11:50:33AM -0600, Jens Axboe wrote:
> On 8/10/20 8:37 AM, Jens Axboe wrote:
> > On 8/10/20 5:44 AM, peterz@...radead.org wrote:
> >> On Sat, Aug 08, 2020 at 03:43:50PM -0600, Jens Axboe wrote:
> >>> Any pre-existing caller of this function uses 'true' to signal to use
> >>> notifications or not, but we now also have signaled notifications.
> >>> Update existing callers that specify 'true' for notify to use the
> >>> updated TWA_RESUME instead.
> >>>
> >>> This was noted in the original commit as well:
> >>>
> >>> e91b48162332 ("task_work: teach task_work_add() to do signal_wake_up()")
> >>>
> >>> Cc: Oleg Nesterov <oleg@...hat.com>
> >>> Cc: Peter Zijlstra <peterz@...radead.org>
> >>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> >>>
> >>
> >> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> >>
> >> How do you want to route this?
> > 
> > I don't really care, as I have no dependencies on it. Feel free to queue
> > it up! It's just sitting at the top of my io_uring branch right now,
> > but that's because I had to stuff it somewhere. Easy to pop off the top.
> 
> FWIW, I dropped this from my branch, so would be great if you or Oleg
> could push this one upstream.

Will do, thanks!