[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHk-=wgyF30ap_tREfey7J9w0MyYDxso1ui-e98U0yYi9pPmhQ@mail.gmail.com>
Date: Mon, 10 Aug 2020 13:59:44 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Peter Xu <peterx@...hat.com>
Cc: Linux-MM <linux-mm@...ck.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Marty Mcfadden <mcfadden8@...l.gov>,
Andrea Arcangeli <aarcange@...hat.com>,
Jann Horn <jannh@...gle.com>, Christoph Hellwig <hch@....de>,
Oleg Nesterov <oleg@...hat.com>,
Kirill Shutemov <kirill@...temov.name>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH v2] mm/gup: Allow real explicit breaking of COW
On Mon, Aug 10, 2020 at 1:51 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> See? That's the whole point. It doesn't _matter_ if you're only
> reading the data, without the COW you may be reading the _wrong_ data.
Example safe users:
- if you hold the mmap_sem the whole time, you're fine
- if you only look up the page mapping for some tracing reasons, you're fine
- if you can explain some other reason why you don't care that some
other process might be changing the data from under you, you might be
fine.
But the point is, you need to _explain_ it. Not just say "I don't want COW".
Linus
Powered by blists - more mailing lists