linux-kernel - RE: [PATCH v3 0/3] clk: zynqmp: Add firmware specific clock flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR02MB562261B10DBF08A58FF066B2A7440@BYAPR02MB5622.namprd02.prod.outlook.com>
Date:   Mon, 10 Aug 2020 22:06:13 +0000
From:   Amit Sunil Dhamne <amitsuni@...inx.com>
To:     Amit Sunil Dhamne <amitsuni@...inx.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "m.tretter@...gutronix.de" <m.tretter@...gutronix.de>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        Michal Simek <michals@...inx.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
CC:     Rajan Vaja <RAJANV@...inx.com>, Jolly Shah <JOLLYS@...inx.com>,
        Tejas Patel <TEJASP@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 0/3] clk: zynqmp: Add firmware specific clock flags

Hi Stephen, Reviewers,
I wanted to gently follow up on the review of this patch.

Thanks,
Amit

> -----Original Message-----
> From: Amit Sunil Dhamne <amit.sunil.dhamne@...inx.com>
> Sent: Monday, August 3, 2020 11:44 PM
> To: mturquette@...libre.com; m.tretter@...gutronix.de;
> sboyd@...nel.org; Michal Simek <michals@...inx.com>;
> mark.rutland@....com; linux-clk@...r.kernel.org
> Cc: Rajan Vaja <RAJANV@...inx.com>; Jolly Shah <JOLLYS@...inx.com>; Tejas
> Patel <TEJASP@...inx.com>; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; Amit Sunil Dhamne <amitsuni@...inx.com>
> Subject: [PATCH v3 0/3] clk: zynqmp: Add firmware specific clock flags
> 
> Currently firmware is maintaining CCF specific flags and provides to CCF as it
> is. But CCF flag numbers may change and that shouldn't mean that the
> firmware needs to change. The firmware should have its own 'flag number
> space' that is distinct from the common clk framework's 'flag number space'.
> So use firmware specific clock flags in ZynqMP clock driver instead of CCF
> flags.
> 
> Changes in v3:
>  - Modify helper function signature to map zynqmp (common)flags with CCF
>  - Add helper function to map zynqmp (mux & divider)flags with CCF flags
> 
> Changes in v2:
>  - Add helper function to map zynqmp (common)flags with CCF flags.
>  - Mapped zynqmp clock flags with CCF flags from
>    zynqmp_clk_register_*() functions instead of
>    __zynqmp_clock_get_topology() which is changing the flags to struct
>    clk_init_data instead of the struct clock_topology.
> 
> Rajan Vaja (3):
>   clk: zynqmp: Use firmware specific common clock flags
>   clk: zynqmp: Use firmware specific divider clock flags
>   clk: zynqmp: Use firmware specific mux clock flags
> 
>  drivers/clk/zynqmp/clk-gate-zynqmp.c |  4 +++-  drivers/clk/zynqmp/clk-
> mux-zynqmp.c  | 26 +++++++++++++++++++++--
>  drivers/clk/zynqmp/clk-zynqmp.h      | 41
> ++++++++++++++++++++++++++++++++++++
>  drivers/clk/zynqmp/clkc.c            | 32 +++++++++++++++++++++++++++-
>  drivers/clk/zynqmp/divider.c         | 29 ++++++++++++++++++++++---
>  drivers/clk/zynqmp/pll.c             |  4 +++-
>  6 files changed, 128 insertions(+), 8 deletions(-)
> 
> --
> 2.7.4