| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202008110732.cIJ0Afx8%lkp@intel.com>
Date: Tue, 11 Aug 2020 07:42:35 +0800
From: kernel test robot <lkp@...el.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/misc/habanalabs/common/firmware_if.c:371:18: warning:
Shifting signed 32-bit value by 31 bits is undefined behaviour
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7
commit: 7b16a15524d5db449cf5e529602610cdf04eddab habanalabs: fix up absolute include instructions
date: 13 days ago
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/misc/habanalabs/common/hw_queue.c:294:8: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << CQ_ENTRY_READY_SHIFT));
^
--
>> drivers/misc/habanalabs/common/firmware_if.c:371:18: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
if (!(err_val & CPU_BOOT_ERR0_ENABLED))
^
--
>> drivers/misc/habanalabs/gaudi/gaudi.c:3941:20: warning: Variable 'new_dma_pkt->ctl' is reassigned a value before the old one has been used. [redundantAssignment]
new_dma_pkt->ctl = cpu_to_le32(ctl);
^
drivers/misc/habanalabs/gaudi/gaudi.c:3935:20: note: Variable 'new_dma_pkt->ctl' is reassigned a value before the old one has been used.
new_dma_pkt->ctl = user_dma_pkt->ctl;
^
drivers/misc/habanalabs/gaudi/gaudi.c:3941:20: note: Variable 'new_dma_pkt->ctl' is reassigned a value before the old one has been used.
new_dma_pkt->ctl = cpu_to_le32(ctl);
^
>> drivers/misc/habanalabs/gaudi/gaudi.c:6249:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = hl_poll_timeout(
^
drivers/misc/habanalabs/gaudi/gaudi.c:6240:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = hl_poll_timeout(
^
drivers/misc/habanalabs/gaudi/gaudi.c:6249:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = hl_poll_timeout(
^
>> drivers/misc/habanalabs/gaudi/gaudi.c:658:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << GAUDI_PKT_CTL_MB_SHIFT));
^
drivers/misc/habanalabs/gaudi/gaudi.c:2301:34: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
gaudi->hw_cap_initialized |= 1 << (HW_CAP_TPC_SHIFT + tpc_id);
^
drivers/misc/habanalabs/gaudi/gaudi.c:2503:3: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmDMA0_QM_CGM_CFG + qman_offset,
^
drivers/misc/habanalabs/gaudi/gaudi.c:2514:3: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmDMA0_QM_CGM_CFG + qman_offset,
^
drivers/misc/habanalabs/gaudi/gaudi.c:2520:3: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmMME0_QM_CGM_CFG, QMAN_COMMON_CP_CGM_PWR_GATE_EN);
^
drivers/misc/habanalabs/gaudi/gaudi.c:2525:3: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmMME2_QM_CGM_CFG, QMAN_COMMON_CP_CGM_PWR_GATE_EN);
^
drivers/misc/habanalabs/gaudi/gaudi.c:2535:3: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmTPC0_QM_CGM_CFG + qman_offset,
^
drivers/misc/habanalabs/gaudi/gaudi.c:2884:2: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmPSOC_GLOBAL_CONF_SOFT_RST_CFG_L, CFG_RST_L_TPC_MASK);
^
drivers/misc/habanalabs/gaudi/gaudi.c:2896:2: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
WREG32(mmPSOC_GLOBAL_CONF_SW_ALL_RST_CFG_L,
^
drivers/misc/habanalabs/gaudi/gaudi.c:3441:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << GAUDI_PKT_CTL_MB_SHIFT);
^
drivers/misc/habanalabs/gaudi/gaudi.c:4246:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << GAUDI_PKT_CTL_MB_SHIFT);
^
drivers/misc/habanalabs/gaudi/gaudi.c:4258:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << GAUDI_PKT_CTL_MB_SHIFT);
^
drivers/misc/habanalabs/gaudi/gaudi.c:4294:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << GAUDI_PKT_CTL_MB_SHIFT));
^
drivers/misc/habanalabs/gaudi/gaudi.c:4902:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << GAUDI_PKT_CTL_MB_SHIFT);
^
--
>> drivers/misc/habanalabs/gaudi/gaudi_security.c:519:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_CTRL_QM_SLV_LBW_CLK_EN & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:560:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_PQ_BASE_LO_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:597:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_PQ_STS0_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:617:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_CQ_TSIZE_0 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:650:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_CQ_TSIZE_STS_4 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:687:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_CP_MSG_BASE2_ADDR_LO_1 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:724:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_CP_LDMA_DST_BASE_LO_OFFSET_2 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:756:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_CP_BARRIER_CFG_2 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:813:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_ARB_MST_AVAIL_CRED_23 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:871:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME0_QM_ARB_MST_CRED_STS_19 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:954:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME1_CTRL_QM_SLV_LBW_CLK_EN & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:998:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_CTRL_QM_SLV_LBW_CLK_EN & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1039:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_PQ_BASE_LO_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1076:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_PQ_STS0_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1096:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_CQ_TSIZE_0 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1129:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_CQ_TSIZE_STS_4 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1166:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_CP_MSG_BASE2_ADDR_LO_1 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1203:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_CP_LDMA_DST_BASE_LO_OFFSET_2 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1235:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_CP_BARRIER_CFG_2 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1292:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_ARB_MST_AVAIL_CRED_23 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1351:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME2_QM_ARB_MST_CRED_STS_19 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1434:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmMME3_CTRL_QM_SLV_LBW_CLK_EN & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1517:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_PQ_BASE_LO_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1554:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_PQ_STS0_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1574:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_CQ_TSIZE_0 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1607:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_CQ_TSIZE_STS_4 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1644:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_CP_MSG_BASE2_ADDR_LO_1 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1681:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_2 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1714:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_CP_BARRIER_CFG_2 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1771:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_ARB_MST_AVAIL_CRED_23 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1830:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA0_QM_ARB_MST_CRED_STS_19 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1912:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA1_QM_PQ_BASE_LO_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1949:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA1_QM_PQ_STS0_3 & 0x7F) >> 2);
^
drivers/misc/habanalabs/gaudi/gaudi_security.c:1969:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
mask |= 1 << ((mmDMA1_QM_CQ_TSIZE_0 & 0x7F) >> 2);
vim +371 drivers/misc/habanalabs/common/firmware_if.c
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 356
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 357 static void fw_read_errors(struct hl_device *hdev, u32 boot_err0_reg)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 358 {
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 359 u32 err_val;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 360
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 361 /* Some of the firmware status codes are deprecated in newer f/w
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 362 * versions. In those versions, the errors are reported
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 363 * in different registers. Therefore, we need to check those
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 364 * registers and print the exact errors. Moreover, there
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 365 * may be multiple errors, so we need to report on each error
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 366 * separately. Some of the error codes might indicate a state
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 367 * that is not an error per-se, but it is an error in production
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 368 * environment
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 369 */
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 370 err_val = RREG32(boot_err0_reg);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 @371 if (!(err_val & CPU_BOOT_ERR0_ENABLED))
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 372 return;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 373
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 374 if (err_val & CPU_BOOT_ERR0_DRAM_INIT_FAIL)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 375 dev_err(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 376 "Device boot error - DRAM initialization failed\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 377 if (err_val & CPU_BOOT_ERR0_FIT_CORRUPTED)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 378 dev_err(hdev->dev, "Device boot error - FIT image corrupted\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 379 if (err_val & CPU_BOOT_ERR0_TS_INIT_FAIL)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 380 dev_err(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 381 "Device boot error - Thermal Sensor initialization failed\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 382 if (err_val & CPU_BOOT_ERR0_DRAM_SKIPPED)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 383 dev_warn(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 384 "Device boot warning - Skipped DRAM initialization\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 385 if (err_val & CPU_BOOT_ERR0_BMC_WAIT_SKIPPED)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 386 dev_warn(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 387 "Device boot error - Skipped waiting for BMC\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 388 if (err_val & CPU_BOOT_ERR0_NIC_DATA_NOT_RDY)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 389 dev_err(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 390 "Device boot error - Serdes data from BMC not available\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 391 if (err_val & CPU_BOOT_ERR0_NIC_FW_FAIL)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 392 dev_err(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 393 "Device boot error - NIC F/W initialization failed\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 394 }
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c Oded Gabbay 2020-03-26 395
:::::: The code at line 371 was first introduced by commit
:::::: 7e1c07dd35250971cd29c60c786ac676179eb7f9 habanalabs: unify and improve device cpu init
:::::: TO: Oded Gabbay <oded.gabbay@...il.com>
:::::: CC: Oded Gabbay <oded.gabbay@...il.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists