linux-kernel - Re: [PATCH] drm/vkms: add missing platform_device_unregister() in vkms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200810133238.GW2352366@phenom.ffwll.local>
Date:   Mon, 10 Aug 2020 15:32:38 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vkms: add missing platform_device_unregister() in
 vkms_init()

On Mon, Aug 10, 2020 at 09:00:11PM +0800, Qinglang Miao wrote:
> When vkms_init() get into out_put, the unregister call of
> vkms_device->platform is missing. So add it before return.
> 
> Fixes: c27f0cc4d43a "drm/vkms: enable cursor by default"

This is the wrong commit, I fixed that up while applying.
-Daniel

> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 57a8a397d..83dd5567d 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -190,8 +190,8 @@ static int __init vkms_init(void)
>  
>  out_put:
>  	drm_dev_put(&vkms_device->drm);
> +	platform_device_unregister(vkms_device->platform);
>  	return ret;
> -
>  out_unregister:
>  	platform_device_unregister(vkms_device->platform);
>  out_free:
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch