linux-kernel - Re: [PATCH] regulator: fix pointer table overallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200810162556.GA3394@qmqm.qmqm.pl>
Date:   Mon, 10 Aug 2020 18:25:56 +0200
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Mark Brown <broonie@...nel.org>
Cc:     Dmitry Osipenko <digetx@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: fix pointer table overallocation

On Mon, Aug 10, 2020 at 01:37:47PM +0100, Mark Brown wrote:
> On Sun, Aug 09, 2020 at 10:44:25PM +0300, Dmitry Osipenko wrote:
> > 09.08.2020 22:21, Michał Mirosław пишет:
> > > The code allocates sizeof(regulator_dev) for a pointer. Make it less
> > > generous. Let kcalloc() calculate the size, while at it.
> > > 
> > > Cc: stable@...r.kernel.org
> > > Fixes: d8ca7d184b33 ("regulator: core: Introduce API for regulators coupling customization")
> 
> > Hello, Michał! Thank you for the patch! Not sure whether it's worthwhile
> > to backport this change since it's an improvement, I'll leave it to Mark
> > to decide, otherwise looks good to me.
> 
> Yeah, this is more a performance improvement than a fix.

Should I resend without Cc: stable?

Best Regards,
Michał Mirosław