linux-kernel - Re: [PATCH v1 1/2] ite-it6505 change trigger conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200810182712.GA408647@ravnborg.org>
Date:   Mon, 10 Aug 2020 20:27:12 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     allen <allen.chen@....com.tw>
Cc:     Jau-Chih Tseng <Jau-Chih.Tseng@....com.tw>,
        Hermes Wu <Hermes.Wu@....com.tw>,
        Kenneth Hung <Kenneth.Hung@....com.tw>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] ite-it6505 change trigger conditions

Hi Allen.

On Mon, Aug 10, 2020 at 05:53:17PM +0800, allen wrote:
> it6505 changes trigger conditions.
> ---
>  Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 2c50016..bf0e889 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -73,7 +73,7 @@ examples:
>  
>          dp-bridge@5c {
>              compatible = "ite,it6505";
> -            interrupts = <152 IRQ_TYPE_EDGE_FALLING 152 0>;
> +            interrupts = <152 IRQ_TYPE_LEVEL_LOW 152 0>;
>              reg = <0x5c>;
>              pinctrl-names = "default";
>              pinctrl-0 = <&it6505_pins>;
I fail to see the need for this. The example shall describe the binding
and is not necessarily a correct description of the HW.
People should look in the dts file for the HW descriptions, not the
binding examples. So I have dropped this patch.

	Sam

> -- 
> 1.9.1