linux-kernel - Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200811222602.GA10181@amd>
Date:   Wed, 12 Aug 2020 00:26:02 +0200
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     jacek.anaszewski@...il.com, robh@...nel.org, marek.behun@....cz,
        devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB
 LED driver

Hi!

> >>Well it depends on where we want to create the default cache values.
> >>
> >>Either we run through a for..loop during driver probe and delay device start
> >>up or we keep the simple arrays and increase the driver total size.
> >for loop will be better.
> >
> >Plus, REGCACHE_RBTREE is very likely overkill.
> 
> Well if I eliminate the reg_cache then I can eliminate the defaults too.

I'm not asking for that. But please investigate REGCACHE_FLAT.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)