linux-kernel - Re: [PATCH] net: Fix potential memory leak in proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200811.153718.832799152733810830.davem@davemloft.net>
Date:   Tue, 11 Aug 2020 15:37:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     kuba@...nel.org, edumazet@...gle.com, kafai@...com,
        daniel@...earbox.net, jakub@...udflare.com, keescook@...omium.org,
        zhang.lin16@....com.cn, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Fix potential memory leak in proto_register()

From: Miaohe Lin <linmiaohe@...wei.com>
Date: Mon, 10 Aug 2020 08:16:58 -0400

> If we failed to assign proto idx, we free the twsk_slab_name but forget to
> free the twsk_slab. Add a helper function tw_prot_cleanup() to free these
> together and also use this helper function in proto_unregister().
> 
> Fixes: b45ce32135d1 ("sock: fix potential memory leak in proto_register()")
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Applied and queued up for -stable, thanks.