[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200811224602.GF3370567@xps15>
Date: Tue, 11 Aug 2020 16:46:02 -0600
From: Mathieu Poirier <mathieu.poirier@...aro.org>
To: peng.fan@....com
Cc: ohad@...ery.com, bjorn.andersson@...aro.org, robh+dt@...nel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, o.rempel@...gutronix.de, linux-imx@....com,
linux-remoteproc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] remoteproc: imx_rproc: add elf memory hooks
On Tue, Jul 28, 2020 at 05:31:13PM +0800, peng.fan@....com wrote:
> From: Peng Fan <peng.fan@....com>
>
> Please not apply 2/2 for now, this 2/2 has not gone through
> test on all i.MX8 platforms.
Why sending patches to the mailing list if they are not ready to be applied?
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> drivers/remoteproc/imx_rproc.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 8957ed271d20..8ad860c65256 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -6,6 +6,7 @@
> #include <linux/clk.h>
> #include <linux/err.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> @@ -241,10 +242,22 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len)
> return va;
> }
>
> +static void *imx_rproc_memcpy(struct rproc *rproc, void *dest, const void *src, size_t count)
> +{
> + memcpy_toio((void * __iomem)dest, src, count);
> +}
> +
> +static void *imx_rproc_memset(struct rproc *rproc, void *s, int c, size_t count)
> +{
> + memset_io((void * __iomem)s, c, count);
> +}
> +
> static const struct rproc_ops imx_rproc_ops = {
> .start = imx_rproc_start,
> .stop = imx_rproc_stop,
> .da_to_va = imx_rproc_da_to_va,
> + .memset = imx_rproc_memset,
> + .memcpy = imx_rproc_memcpy,
That won't work - you are modifying how _all_ the platforms out there are
working. As I indicated on the series on iMX8M, add a field to imx_rproc_dcfg
and apply the correct memory accessor based on that.
It might also suggest that it is time to split the iMX platform drivers, i.e
older MCU and iMX8M.
> };
>
> static int imx_rproc_addr_init(struct imx_rproc *priv,
> --
> 2.16.4
>
Powered by blists - more mailing lists