linux-kernel - RE: [PATCH 1/2] irqchip/imx-intmux: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916C979E73D47F21E29F3EEF5450@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Tue, 11 Aug 2020 06:02:24 +0000
From:   Anson Huang <anson.huang@....com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "maz@...nel.org" <maz@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify
 error handling

Hi, Ahmad


> Subject: Re: [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify
> error handling
> 
> Hello,
> 
> On 8/11/20 6:25 AM, Anson Huang wrote:
> > dev_err_probe() can reduce code size, uniform error handling and
> > record the defer probe reason etc., use it to simplify the code.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> >  drivers/irqchip/irq-imx-intmux.c | 10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-imx-intmux.c
> > b/drivers/irqchip/irq-imx-intmux.c
> > index e35b7b0..2f51ec9 100644
> > --- a/drivers/irqchip/irq-imx-intmux.c
> > +++ b/drivers/irqchip/irq-imx-intmux.c
> > @@ -226,12 +226,10 @@ static int imx_intmux_probe(struct
> platform_device *pdev)
> >  	}
> >
> >  	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
> > -	if (IS_ERR(data->ipg_clk)) {
> > -		ret = PTR_ERR(data->ipg_clk);
> > -		if (ret != -EPROBE_DEFER)
> > -			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
> > -		return ret;
> > -	}
> > +	if (IS_ERR(data->ipg_clk))
> > +		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
> > +				     "failed to get ipg clk: %ld\n",
> > +				     PTR_ERR(data->ipg_clk));
> 
> Haven't used dev_err_probe myself yet, but the function does
> 
> 	if (err != -EPROBE_DEFER) {
> 		dev_err(dev, "error %d: %pV", err, &vaf);
> 
> so your message would become
> 
> 	"error %d: failed to get ipg clk: %d\n"
> 
> printing the same error code twice. If so, you should drop the second.

Correct, I will fix it in V2.

Thanks,
Anson