linux-kernel - Re: [PATCH 0/5] Some clean-ups for bio merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200811114919.GA84227@VM20190228-100.tbsite.net>
Date:   Tue, 11 Aug 2020 19:49:19 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     axboe@...nel.dk
Cc:     ming.lei@...hat.com, hch@....de, baolin.wang7@...il.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] Some clean-ups for bio merge

Hi,

On Wed, Jul 29, 2020 at 11:28:32AM +0800, Baolin Wang wrote:
> Hi,
> 
> There are some duplicated code when trying to merge bio from pluged list
> and software queue, thus this patch set did some clean-ups when merging
> a bio. Any comments are welcome. Thanks.

Any comments for this patch set? Thanks.

> 
> Baolin Wang (5):
>   block: Move bio merge related functions into blk-merge.c
>   block: Remove redundant blk_mq_sched_allow_merge() validation
>   block: Add a new helper to attempt to merge a bio
>   block: Remove blk_mq_attempt_merge() function
>   block: Remove __blk_mq_sched_bio_merge() helper
> 
>  block/blk-core.c     | 156 -----------------------------------------------
>  block/blk-merge.c    | 168 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  block/blk-mq-sched.c |  64 ++++++--------------
>  block/blk-mq-sched.h |  13 +---
>  block/blk.h          |   9 +++
>  5 files changed, 197 insertions(+), 213 deletions(-)
> 
> -- 
> 1.8.3.1