linux-kernel - RE: [PATCH 1/2] scsi: ufs: Fix interrupt error message for shared interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR04MB4640A7618C2425D6E837C20EFC450@SN6PR04MB4640.namprd04.prod.outlook.com>
Date:   Tue, 11 Aug 2020 12:20:26 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        Can Guo <cang@...eaurora.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Fix interrupt error message for shared
 interrupts

 
> The interrupt might be shared, in which case it is not an error for the
> interrupt handler to be called when the interrupt status is zero, so
> remove the message print and register dump.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code")
> ---
>  drivers/scsi/ufs/ufshcd.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index cdcf56679b41..d7522dba4dcf 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5994,12 +5994,6 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba)
>                 intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS);
>         } while (intr_status && --retries);
> 
> -       if (retval == IRQ_NONE) {
Maybe    if (enabled_intr_status && retval == IRQ_NONE) { ?

Thanks,
Avri