lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 11 Aug 2020 09:24:10 -0500
From:   David Lechner <david@...hnology.com>
To:     Alex Dewar <alex.dewar90@...il.com>,
        Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Sekhar Nori <nsekhar@...com>,
        Bartosz Gołaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig
 options

On 8/9/20 1:54 PM, Alex Dewar wrote:
> This battery appears only to be used by a single board (DA850), so it
> makes sense to add this to the Kconfig file so that users don't build
> the module unnecessarily. It currently seems to be built for the x86
> Arch Linux kernel where it's probably not doing much good.

It would probably also make sense to add "default n" since it only
applies to one board in the entire arch.

BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate
defconfig file, so I don't think it would break anything.

> 
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
>   drivers/power/supply/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index faf2830aa1527..9f76e2f47ac6d 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -164,7 +164,7 @@ config BATTERY_DS2782
>   
>   config BATTERY_LEGO_EV3
>   	tristate "LEGO MINDSTORMS EV3 battery"
> -	depends on OF && IIO && GPIOLIB
> +	depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST)
>   	help
>   	  Say Y here to enable support for the LEGO MINDSTORMS EV3 battery.
>   
> 

Powered by blists - more mailing lists