lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Aug 2020 09:47:23 +0800 From: Yingjoe Chen <yingjoe.chen@...iatek.com> To: Fengping Yu <fengping.yu@...iatek.com> CC: Rob Herring <robh+dt@...nel.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Marco Felsch <m.felsch@...gutronix.de>, <linux-input@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad Hi, On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote: > From: "fengping.yu" <fengping.yu@...iatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@...iatek.com> > --- > .../devicetree/bindings/input/mtk-kpd.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml > > diff --git a/Documentation/devicetree/bindings/input/mtk-kpd.yaml b/Documentation/devicetree/bindings/input/mtk-kpd.yaml > new file mode 100644 > index 000000000000..d74dd8a6fbde <...> > + keypad,num-columns: > + description: Number of column lines connected to the keypad controller, > + it is not equal to PCB columns number, instead you should add required value > + for each IC. If not specified, the default value is 1. > + > + keypad,num-rows: > + description: Number of row lines connected to the keypad controller, it is > + not equal to PCB rows number, instead you should add required value for each IC. > + If not specified, the default value is 1. Your source code can't really handle dts without rows/columns properties. Also, the default value doesn't make any sense. No IC will have rows or columns set to 1. Since these are IC specified, not board specified, I think you should just have the correct numbers in driver. Joe.C
Powered by blists - more mailing lists