linux-kernel - Re: [PATCH] [v2] tools/objtool: Fix unnecessary jumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3cc66bb-bdf0-bc53-f7d3-75cf8d5f94d4@linux.vnet.ibm.com>
Date:   Tue, 11 Aug 2020 20:54:10 +0530
From:   Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:     Youling Tang <tangyouling@...ngson.cn>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] tools/objtool: Fix unnecessary jumps

On 11/08/20 9:48 am, Youling Tang wrote:
> There is no need to jump to the "out" tag when "ret < 0", just return
> directly to "ret".
> 
> Signed-off-by: Youling Tang <tangyouling@...ngson.cn>

the patch looks good to me, the commit message doesn't explain the
reason for the change. It can be written like:

"Previously cleanup() function was called under the out label for both
fatal errors (ret < 0) and warnings.  Now that cleanup() function is
removed, the out label is no longer required. Remove it and return
immediately for the fatal errors with ret as return code and 0 for
warnings."

Reviewed-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>

-- 
Kamalesh