linux-kernel - Re: [PATCH 02/33] spmi, regulator, mfd: add drivers for hikey970 SPMI PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Aug 2020 18:08:37 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Mayulong <mayulong1@...wei.com>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 02/33] spmi, regulator, mfd: add drivers for hikey970
 SPMI PMIC

Em Tue, 11 Aug 2020 16:58:10 +0100
Mark Brown <broonie@...nel.org> escreveu:

> On Tue, Aug 11, 2020 at 05:41:28PM +0200, Mauro Carvalho Chehab wrote:
> 
> >  drivers/mfd/hisi_pmic_spmi.c            | 759 ++++++++++++++++++++++++
> >  drivers/regulator/hisi_regulator_spmi.c | 741 +++++++++++++++++++++++
> >  drivers/spmi/hisi-spmi-controller.c     | 390 ++++++++++++
> >  include/linux/mfd/hisi_pmic.h           | 165 ++++++  
> 
> This is a single patch for three subsystems, please split it into per
> subsystem patches.

Ok, I'll split on a next version. 


Yet, it would be good to have all tree drivers applied via the same tree,
as those drivers are needed altogether in order for this PMIC to work:

- The SPMI controller driver talks with the hardware and provides
  support via the SPMI bus calls;
- The MFD PMIC driver binds into the SPMI bus and provide support
  for interrupts. It also has support for binding the regulator
  driver;
- The regulator driver needs the PMIC driver (which in turn needs
  the SPMI bus) in order to be able to talk with the hardware and
  set the power supplied.

That's basically why I opted to send the entire series altogether.

Thanks,
Mauro