[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5a9a2338-1348-a84b-36f2-280d603298af@linux.intel.com>
Date: Tue, 11 Aug 2020 10:04:07 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: kernel test robot <lkp@...el.com>,
Ryan Lee <ryans.lee@...imintegrated.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Mark Brown <broonie@...nel.org>,
Naveen Manohar <naveen.m@...el.com>,
Rander Wang <rander.wang@...ux.intel.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>
Subject: Re: sound/soc/codecs/max98373-sdw.c:325:4: warning: Variable 'i' is
reassigned a value before the old one has been used.
> cppcheck warnings: (new ones prefixed by >>)
>
>>> sound/soc/codecs/max98373-sdw.c:325:4: warning: Variable 'i' is reassigned a value before the old one has been used. [redundantAssignment]
> i = 0;
> ^
> sound/soc/codecs/max98373-sdw.c:313:4: note: Variable 'i' is reassigned a value before the old one has been used.
> i++;
> ^
the variable is incremented at the end of the loop, and reset at the
start of a new loop, not sure how to avoid this warning.
> sound/soc/codecs/max98373-sdw.c:325:4: note: Variable 'i' is reassigned a value before the old one has been used.
> i = 0;
> ^
> sound/soc/codecs/max98373-sdw.c:344:9: warning: Variable 'i' is reassigned a value before the old one has been used. [redundantAssignment]
> for (i = 0; i < num_of_ports; i++)
> ^
> sound/soc/codecs/max98373-sdw.c:333:4: note: Variable 'i' is reassigned a value before the old one has been used.
> i++;
> ^
> sound/soc/codecs/max98373-sdw.c:344:9: note: Variable 'i' is reassigned a value before the old one has been used.
> for (i = 0; i < num_of_ports; i++)
> ^
Same problem, the variable is reset at the start of a new loop, but the
problem is solved - that code was removed in the latest code (to be
submitted after the merge window).
> vim +/i +325 sound/soc/codecs/max98373-sdw.c
>
> 281
> 282 static int max98373_read_prop(struct sdw_slave *slave)
> 283 {
> 284 struct sdw_slave_prop *prop = &slave->prop;
> 285 int nval, i, num_of_ports;
> 286 u32 bit;
> 287 unsigned long addr;
> 288 struct sdw_dpn_prop *dpn;
> 289
> 290 /* BITMAP: 00001000 Dataport 3 is active */
> 291 prop->source_ports = BIT(3);
> 292 /* BITMAP: 00000010 Dataport 1 is active */
> 293 prop->sink_ports = BIT(1);
> 294 prop->paging_support = true;
> 295 prop->clk_stop_timeout = 20;
> 296
> 297 nval = hweight32(prop->source_ports);
> 298 num_of_ports = nval;
> 299 prop->src_dpn_prop = devm_kcalloc(&slave->dev, nval,
> 300 sizeof(*prop->src_dpn_prop),
> 301 GFP_KERNEL);
> 302 if (!prop->src_dpn_prop)
> 303 return -ENOMEM;
> 304
> 305 i = 0;
> 306 dpn = prop->src_dpn_prop;
> 307 addr = prop->source_ports;
> 308 for_each_set_bit(bit, &addr, 32) {
> 309 dpn[i].num = bit;
> 310 dpn[i].type = SDW_DPN_FULL;
> 311 dpn[i].simple_ch_prep_sm = true;
> 312 dpn[i].ch_prep_timeout = 10;
> 313 i++;
> 314 }
> 315
> 316 /* do this again for sink now */
> 317 nval = hweight32(prop->sink_ports);
> 318 num_of_ports += nval;
> 319 prop->sink_dpn_prop = devm_kcalloc(&slave->dev, nval,
> 320 sizeof(*prop->sink_dpn_prop),
> 321 GFP_KERNEL);
> 322 if (!prop->sink_dpn_prop)
> 323 return -ENOMEM;
> 324
> > 325 i = 0;
> 326 dpn = prop->sink_dpn_prop;
> 327 addr = prop->sink_ports;
> 328 for_each_set_bit(bit, &addr, 32) {
> 329 dpn[i].num = bit;
> 330 dpn[i].type = SDW_DPN_FULL;
> 331 dpn[i].simple_ch_prep_sm = true;
> 332 dpn[i].ch_prep_timeout = 10;
> 333 i++;
> 334 }
> 335
> 336 /* Allocate port_ready based on num_of_ports */
> 337 slave->port_ready = devm_kcalloc(&slave->dev, num_of_ports,
> 338 sizeof(*slave->port_ready),
> 339 GFP_KERNEL);
> 340 if (!slave->port_ready)
> 341 return -ENOMEM;
> 342
> 343 /* Initialize completion */
> 344 for (i = 0; i < num_of_ports; i++)
> 345 init_completion(&slave->port_ready[i]);
> 346
> 347 /* set the timeout values */
> 348 prop->clk_stop_timeout = 20;
> 349
> 350 return 0;
> 351 }
> 352
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
Powered by blists - more mailing lists