linux-kernel - Re: [PATCH] tools/objtool: Fix unnecessary jumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Aug 2020 10:18:52 +0800
From:   Youling Tang <tangyouling@...ngson.cn>
To:     Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/objtool: Fix unnecessary jumps

Thank you for your reply and suggestions, I will remove

the "out" label code.

Thanks,
Youling


On 08/10/2020 08:57 PM, Kamalesh Babulal wrote:
> On 10/08/20 9:36 am, Youling Tang wrote:
>> There is no need to jump to the "out" tag when "ret < 0", just return
>> directly to "ret".
>>
>> Signed-off-by: Youling Tang <tangyouling@...ngson.cn>
>> ---
>>   tools/objtool/check.c | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
>> index e034a8f..94b166d 100644
>> --- a/tools/objtool/check.c
>> +++ b/tools/objtool/check.c
> [snip]
>
>>   	if (file.elf->changed) {
>>   		ret = elf_write(file.elf);
>>   		if (ret < 0)
>> -			goto out;
>> +			return ret;
>>   	}
>>
>>   out:
> the out label code is no more required with this change, so remove
> it and return 0 for warnings for now.  Previously cleanup() function
> was called under the out label for both fatal errors (ret < 0) and
> warnings.  Now that cleanup() function is removed, the out label is
> no longer required.
>