linux-kernel - Re: [PATCH net] drivers/net/wan/x25_asy: Added needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200811.103225.204767763010456044.davem@davemloft.net>
Date:   Tue, 11 Aug 2020 10:32:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-x25@...r.kernel.org,
        willemdebruijn.kernel@...il.com, ms@....tdt.de
Subject: Re: [PATCH net] drivers/net/wan/x25_asy: Added needed_headroom and
 a skb->len check

From: Xie He <xie.he.0141@...il.com>
Date: Sat,  8 Aug 2020 19:35:48 -0700

> 1. Added a skb->len check
> 
> This driver expects upper layers to include a pseudo header of 1 byte
> when passing down a skb for transmission. This driver will read this
> 1-byte header. This patch added a skb->len check before reading the
> header to make sure the header exists.
> 
> 2. Added needed_headroom
> 
> When this driver transmits data,
>   first this driver will remove a pseudo header of 1 byte,
>   then the lapb module will prepend the LAPB header of 2 or 3 bytes.
> So the value of needed_headroom in this driver should be 3 - 1.
> 
> Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Cc: Martin Schiller <ms@....tdt.de>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thank you.