lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200811191704.GA524675@ravnborg.org>
Date:   Tue, 11 Aug 2020 21:17:04 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Vinay Simha B N <simhavcs@...il.com>
Cc:     Vinay Simha B N <simhavcs@...il.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Jonas Karlman <jonas@...boo.se>,
        David Airlie <airlied@...ux.ie>,
        Neil Armstrong <narmstrong@...libre.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        Andrzej Hajda <a.hajda@...sung.com>
Subject: Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Hi Vinay.

> > 
> > If Laurent or others identify further things to improve we can take
> > it in-tree.
> 
> Just one thing, please see below.
> 
> > > > >> +       d2l_write(tc->i2c, VTIM1, vtime1);
> > > > >> +       d2l_write(tc->i2c, HTIM2, htime2);
> > > > >> +       d2l_write(tc->i2c, VTIM2, vtime2);
> > > > >> +
> > > > >> +       d2l_write(tc->i2c, VFUEN, VFUEN_EN);
> > > > >> +       d2l_write(tc->i2c, SYSRST, SYS_RST_LCD);
> > > > >> +       d2l_write(tc->i2c, LVPHY0, LV_PHY0_PRBS_ON(4) | LV_PHY0_ND(6));
> > > > >> +
> > > > >> +       dev_dbg(tc->dev, "bus_formats %04x bpc %d\n",
> > > > >> +               connector->display_info.bus_formats[0],
> > > > >> +               tc->bpc);
> > > > >> +       /*
> > > > >> +        * Default hardware register settings of tc358775 configured
> > > > >> +        * with MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA jeida-24 format
> > > > >> +        */
> > > > >> +       if (connector->display_info.bus_formats[0] ==
> > > > >> +               MEDIA_BUS_FMT_RGB888_1X7X4_SPWG) {
> 
> This shouldn't come from the connector, but from the
> drm_bridge_state.output_bus_cfg.format. The drm_bridge_funcs
> .atomic_get_input_bus_fmts() operation likely needs to be implemented.

I trust you will look into this and submit a patch on top of
drm-misc-next.
Please add a proper "Fixes:" tag identifying the commit that introduced
this bug - in this case the commit introducing the driver.

Do not hesitate to reply to all if you have any questions.
We will help you if we can.

	Sam

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ