linux-kernel - Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1210ef6-36ec-9e3f-e686-a87244ea1c33@gmail.com>
Date:   Mon, 10 Aug 2020 19:33:45 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Philippe Mathieu-Daudé <f4bug@...at.org>,
        Álvaro Fernández Rojas <noltari@...il.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jonas Gorski <jonas.gorski@...il.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board



On 8/9/2020 11:49 AM, Philippe Mathieu-Daudé wrote:
> Hi Álvaro,
> 
> On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas
> <noltari@...il.com> wrote:
>>
>> EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI
>> it should also have EHCI.
> 
> This statement isn't correct. OHCI doesn't imply EHCI...
> (although the opposite is almost always true).
> 
> Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller.
> 
> Do you mind rewording the commit description?

Is not it that a single USB port is used and we need the EHCI controller
active in order for the correct speed negotiation to occur?
-- 
Florian