linux-kernel - RE: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR11MB1518201647DEDE4F67E602B791450@MWHPR11MB1518.namprd11.prod.outlook.com>
Date:   Tue, 11 Aug 2020 19:39:04 +0000
From:   "Shaikh, Azhar" <azhar.shaikh@...el.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Prashant Malani <pmalani@...omium.org>
CC:     "bleung@...omium.org" <bleung@...omium.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "groeck@...omium.org" <groeck@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>,
        "Bowman, Casey G" <casey.g.bowman@...el.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>
Subject: RE: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb
 role during disconnect

Hi,

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Sent: Tuesday, August 11, 2020 6:07 AM
> To: Prashant Malani <pmalani@...omium.org>; Shaikh, Azhar
> <azhar.shaikh@...el.com>
> Cc: bleung@...omium.org; enric.balletbo@...labora.com;
> groeck@...omium.org; linux-kernel@...r.kernel.org; Patel, Utkarsh H
> <utkarsh.h.patel@...el.com>; Bowman, Casey G
> <casey.g.bowman@...el.com>; Mani, Rajmohan
> <rajmohan.mani@...el.com>
> Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting
> usb role during disconnect
> 
> Hi,
> 
> On Thu, Aug 06, 2020 at 11:39:08AM -0700, Prashant Malani wrote:
> > I would suggest:
> > - Merging Patch 1 (role set correction) and Patch 2 (moving the
> > usb_role_switch_set_role() inside cros_typec_configure_mux()
> > *but* keep it at the end to preserve existing ordering) into 1 patch.
> > - Add another patch which re-orders the calls and which in the commit
> > message lists out all the reasons why this re-ordering needs to be
> > done.
> >
> > Doing the above will help keep better track of why the changes were
> made.
> 
> So Azhar can you please prepare v3?
> 

Sure, sent v3.

> 
> thanks,
> 
> --
> Heikki

Regards,
Azhar