linux-kernel - Re: [PATCH drm/hisilicon v2 0/3] hibmc clean up and code refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f558a5c-61b6-303a-0c2f-e0f63e9faa10@huawei.com>
Date:   Wed, 12 Aug 2020 15:12:37 +0800
From:   "tiantao (H)" <tiantao6@...wei.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>,
        Tian Tao <tiantao6@...ilicon.com>, <airlied@...ux.ie>,
        <daniel@...ll.ch>, <kraxel@...hat.com>,
        <alexander.deucher@....com>, <tglx@...utronix.de>,
        <dri-devel@...ts.freedesktop.org>, <xinliang.liu@...aro.org>,
        <linux-kernel@...r.kernel.org>
CC:     <linuxarm@...wei.com>
Subject: Re: [PATCH drm/hisilicon v2 0/3] hibmc clean up and code refactoring



在 2020/8/12 15:04, Thomas Zimmermann 写道:
> Hi
> 
> Am 03.08.20 um 02:38 schrieb Tian Tao:
>> patch #1 and #3 is clean up, patch #2 is for code refactoring
> 
> Sorry for all my reviews taking so long. Please merge patch #3 into
> patch #2 and then the series is
> 
thanks,I will send v3 to fix this.
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> 
> I noticed that hibmc use DRM_ERROR in several places. A good follow-up
> patchset would be the conversion to drm_info/drm_warn/drm_error/etc.
> 
I will send another patchset to fix this.
> Best regards
> Thomas
> 
>>
>> Changes since v1:
>> - Rewrite the commits messages and patch name in #1
>> - Rewrite the commits message in #2.
>> - Add the new patch #3
>>
>> Tian Tao (3):
>>    drm/hisilicon: Remove the unused include statements
>>    drm/hisilicon: Code refactoring for hibmc_drv_de
>>    drm/hisilicon: Rename variables to represent the correct meaning
>>
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c   | 58 ++++++------------------
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c  |  5 --
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h  |  2 +
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c |  2 -
>>   4 files changed, 15 insertions(+), 52 deletions(-)
>>
>