linux-kernel - Re: [PATCH] of/address: check for invalid range.cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <812ec088-999d-3b95-4ce6-c84cf3565ea0@canonical.com>
Date:   Wed, 12 Aug 2020 08:32:37 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of/address: check for invalid range.cpu_addr

On 10/08/2020 15:06, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently invalid CPU addresses are not being sanity checked resulting in
> SATA setup failure on a SynQuacer SC2A11 development machine. The original
> check was removed by and earlier commit, so add a sanity check back in
> to avoid this regression.
> 
> Fixes: 7a8b64d17e35 ("of/address: use range parser for of_dma_get_range")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/of/address.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 590493e04b01..764c8b94ec35 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -985,6 +985,11 @@ int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *siz
>  			/* Don't error out as we'd break some existing DTs */
>  			continue;
>  		}
> +		if (range.cpu_addr == OF_BAD_ADDR) {
> +			pr_warn("Translation of DMA address (%llx) to CPU address failed on node (%pOF)\n",
> +				range.cpu_addr, node);
> +			continue;
> +		}
>  		dma_offset = range.cpu_addr - range.bus_addr;
>  
>  		/* Take lower and upper limits */
> 

Hi there, any follow up on this fix? (reviews. etc?)