linux-kernel - drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3730 iwl_trans_pcie_alloc() warn: passing zero to 'ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 12 Aug 2020 16:30:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Johannes Berg <johannes.berg@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Luca Coelho <luciano.coelho@...el.com>
Subject: drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3730
 iwl_trans_pcie_alloc() warn: passing zero to 'ERR_PTR'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fb893de323e2d39f7a1f6df425703a2edbdf56ea
commit: c239feec5038585d8ba622ecc97322e0e2f3398c iwlwifi: pcie: gen2: use DMA pool for byte-count tables
date:   3 months ago
config: parisc-randconfig-m031-20200811 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3730 iwl_trans_pcie_alloc() warn: passing zero to 'ERR_PTR'

Old smatch warnings:
drivers/net/wireless/intel/iwlwifi/pcie/trans.c:236 iwl_pcie_alloc_fw_monitor_block() warn: should '(((1))) << (power - 10)' be a 64 bit type?
drivers/net/wireless/intel/iwlwifi/pcie/trans.c:236 iwl_pcie_alloc_fw_monitor_block() warn: should '(((1))) << (max_power - 10)' be a 64 bit type?

vim +/ERR_PTR +3730 drivers/net/wireless/intel/iwlwifi/pcie/trans.c

f7805b33f9b13a drivers/net/wireless/intel/iwlwifi/pcie/trans.c Lior Cohen         2018-05-03  3718  
a9248de42464e5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Shahar S Matityahu 2019-07-23  3719  	iwl_dbg_tlv_init(trans);
a9248de42464e5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Shahar S Matityahu 2019-07-23  3720  
a42a184458ae95 drivers/net/wireless/iwlwifi/iwl-trans-pcie.c   Emmanuel Grumbach  2012-02-02  3721  	return trans;
a42a184458ae95 drivers/net/wireless/iwlwifi/iwl-trans-pcie.c   Emmanuel Grumbach  2012-02-02  3722  
a8b691e6104e6b drivers/net/wireless/iwlwifi/pcie/trans.c       Johannes Berg      2012-12-27  3723  out_free_ict:
a8b691e6104e6b drivers/net/wireless/iwlwifi/pcie/trans.c       Johannes Berg      2012-12-27  3724  	iwl_pcie_free_ict(trans);
a42a184458ae95 drivers/net/wireless/iwlwifi/iwl-trans-pcie.c   Emmanuel Grumbach  2012-02-02  3725  out_no_pci:
6eb5e529d7e3bf drivers/net/wireless/intel/iwlwifi/pcie/trans.c Emmanuel Grumbach  2015-10-18  3726  	free_percpu(trans_pcie->tso_hdr_page);
8188a18ee2e48c drivers/net/wireless/intel/iwlwifi/pcie/trans.c Johannes Berg      2019-09-19  3727  	destroy_workqueue(trans_pcie->rba.alloc_wq);
8188a18ee2e48c drivers/net/wireless/intel/iwlwifi/pcie/trans.c Johannes Berg      2019-09-19  3728  out_free_trans:
7b501d10b18bc3 drivers/net/wireless/iwlwifi/pcie/trans.c       Johannes Berg      2015-05-22  3729  	iwl_trans_free(trans);
af3f2f740173f8 drivers/net/wireless/iwlwifi/pcie/trans.c       Emmanuel Grumbach  2015-06-04 @3730  	return ERR_PTR(ret);
a42a184458ae95 drivers/net/wireless/iwlwifi/iwl-trans-pcie.c   Emmanuel Grumbach  2012-02-02  3731  }
b8a7547d77782b drivers/net/wireless/intel/iwlwifi/pcie/trans.c Shahar S Matityahu 2018-12-05  3732  

:::::: The code at line 3730 was first introduced by commit
:::::: af3f2f740173f8b5c61dba46f900998c5984ccd9 iwlwifi: pcie: don't panic if pcie transport alloc fails

:::::: TO: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
:::::: CC: Emmanuel Grumbach <emmanuel.grumbach@...el.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30533 bytes)