lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Aug 2020 03:31:38 +0200 From: Michał Mirosław <mirq-linux@...e.qmqm.pl> To: Dmitry Osipenko <digetx@...il.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Vladimir Zapolskiy <vz@...ia.com> Cc: linux-kernel@...r.kernel.org Subject: [PATCH v2 7/7] regulator: remove superfluous lock in regulator_resolve_coupling() The code modifies rdev, but locks c_rdev instead. Remove the lock as this is held together by regulator_list_mutex taken in the caller. Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl> Reviewed-by: Dmitry Osipenko <digetx@...il.com> Fixes: f9503385b187 ("regulator: core: Mutually resolve regulators coupling") --- v2: reword commitmsg --- drivers/regulator/core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index bfd4114d6654..9ca89fee0d7e 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4942,13 +4942,9 @@ static void regulator_resolve_coupling(struct regulator_dev *rdev) return; } - regulator_lock(c_rdev); - c_desc->coupled_rdevs[i] = c_rdev; c_desc->n_resolved++; - regulator_unlock(c_rdev); - regulator_resolve_coupling(c_rdev); } } -- 2.20.1
Powered by blists - more mailing lists