linux-kernel - drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3194 cudbg_collect_flash() error: uninitialized symbol 'rc'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202008130137.OUxQ5REb%lkp@intel.com>
Date:   Thu, 13 Aug 2020 01:29:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vishal Kulkarni <vishal@...lsio.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3194
 cudbg_collect_flash() error: uninitialized symbol 'rc'.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fb893de323e2d39f7a1f6df425703a2edbdf56ea
commit: 17b332f48074e7ee2169ee4268ced6274e1c95c3 cxgb4: add support to read serial flash
date:   8 weeks ago
config: parisc-randconfig-m031-20200811 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3194 cudbg_collect_flash() error: uninitialized symbol 'rc'.

Old smatch warnings:
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3157 cudbg_collect_qdesc() error: uninitialized symbol 'rc'.

vim +/rc +3194 drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c

  3159	
  3160	int cudbg_collect_flash(struct cudbg_init *pdbg_init,
  3161				struct cudbg_buffer *dbg_buff,
  3162				struct cudbg_error *cudbg_err)
  3163	{
  3164		struct adapter *padap = pdbg_init->adap;
  3165		u32 count = padap->params.sf_size, n;
  3166		struct cudbg_buffer temp_buff = {0};
  3167		u32 addr, i;
  3168		int rc;
  3169	
  3170		addr = FLASH_EXP_ROM_START;
  3171	
  3172		for (i = 0; i < count; i += SF_PAGE_SIZE) {
  3173			n = min_t(u32, count - i, SF_PAGE_SIZE);
  3174	
  3175			rc = cudbg_get_buff(pdbg_init, dbg_buff, n, &temp_buff);
  3176			if (rc) {
  3177				cudbg_err->sys_warn = CUDBG_STATUS_PARTIAL_DATA;
  3178				goto out;
  3179			}
  3180			rc = t4_read_flash(padap, addr, n, (u32 *)temp_buff.data, 0);
  3181			if (rc)
  3182				goto out;
  3183	
  3184			addr += (n * 4);
  3185			rc = cudbg_write_and_release_buff(pdbg_init, &temp_buff,
  3186							  dbg_buff);
  3187			if (rc) {
  3188				cudbg_err->sys_warn = CUDBG_STATUS_PARTIAL_DATA;
  3189				goto out;
  3190			}
  3191		}
  3192	
  3193	out:
> 3194		return rc;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30858 bytes)