linux-kernel - Re: [PATCH] erofs: avoid duplicated permission check for "trusted." xattrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18a6a9b7-5967-1929-920a-e34e446944ac@huawei.com>
Date:   Wed, 12 Aug 2020 10:01:03 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <hsiangkao@...hat.com>, <linux-erofs@...ts.ozlabs.org>
CC:     LKML <linux-kernel@...r.kernel.org>, Chao Yu <chao@...nel.org>,
        Hongyu Jin <hongyu.jin@...soc.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH] erofs: avoid duplicated permission check for "trusted."
 xattrs

On 2020/8/11 15:00, Gao Xiang wrote:
> Don't recheck it since xattr_permission() already
> checks CAP_SYS_ADMIN capability.
> 
> Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs")
> 
> Reported-by: Hongyu Jin <hongyu.jin@...soc.com>
> [ Gao Xiang: since it could cause some complex Android overlay
>    permission issue as well on android-5.4+, so it'd be better to
>    backport to 5.4+ rather than pure cleanup on mainline. ]
> Cc: <stable@...r.kernel.org> # 5.4+
> Signed-off-by: Gao Xiang <hsiangkao@...hat.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,