linux-kernel - Re: [PATCH 2/2] nfsd: Fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200812203740.GB13358@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com>
Date:   Wed, 12 Aug 2020 20:37:40 +0000
From:   Frank van der Linden <fllinden@...zon.com>
To:     Alex Dewar <alex.dewar90@...il.com>
CC:     "J. Bruce Fields" <bfields@...ldses.org>,
        Chuck Lever <chuck.lever@...cle.com>,
        <linux-nfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] nfsd: Fix typo in comment

On Wed, Aug 12, 2020 at 03:12:52PM +0100, Alex Dewar wrote:
> 
> Fix typos in nfs4xdr.c.
> 
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
>  fs/nfsd/nfs4xdr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 1a0341fd80f9a..3db789139a71f 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4828,7 +4828,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
>                 slen = strlen(sp);
> 
>                 /*
> -                * Check if this a user. attribute, skip it if not.
> +                * Check if this is a user attribute, skip it if not.
>                  */
>                 if (strncmp(sp, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN))
>                         goto contloop;
> --
> 2.28.0
> 

"this a" should indeed by "this is a", but "user." is not a typo - it is
talking about checking the prefix of the extended attribute, which is
"user.", so the "." is intended to be there.

Thanks,

- Frank