| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Aug 2020 04:31:13 +0800
From: kernel test robot <lkp@...el.com>
To: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
Subject: drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1240
i40e_set_vsi_promisc() error: uninitialized symbol 'aq_ret'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fb893de323e2d39f7a1f6df425703a2edbdf56ea
commit: 37d318d7805f25b672bfd74fc694f19a2ee9665d i40e: Remove scheduling while atomic possibility
date: 7 weeks ago
config: parisc-randconfig-m031-20200811 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1240 i40e_set_vsi_promisc() error: uninitialized symbol 'aq_ret'.
vim +/aq_ret +1240 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1158
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1159 /**
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1160 * i40e_set_vsi_promisc
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1161 * @vf: pointer to the VF struct
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1162 * @seid: VSI number
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1163 * @multi_enable: set MAC L2 layer multicast promiscuous enable/disable
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1164 * for a given VLAN
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1165 * @unicast_enable: set MAC L2 layer unicast promiscuous enable/disable
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1166 * for a given VLAN
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1167 * @vl: List of VLANs - apply filter for given VLANs
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1168 * @num_vlans: Number of elements in @vl
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1169 **/
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1170 static i40e_status
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1171 i40e_set_vsi_promisc(struct i40e_vf *vf, u16 seid, bool multi_enable,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1172 bool unicast_enable, s16 *vl, int num_vlans)
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1173 {
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1174 struct i40e_pf *pf = vf->pf;
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1175 struct i40e_hw *hw = &pf->hw;
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1176 i40e_status aq_ret;
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1177 int i;
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1178
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1179 /* No VLAN to set promisc on, set on VSI */
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1180 if (!num_vlans || !vl) {
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1181 aq_ret = i40e_aq_set_vsi_multicast_promiscuous(hw, seid,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1182 multi_enable,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1183 NULL);
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1184 if (aq_ret) {
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1185 int aq_err = pf->hw.aq.asq_last_status;
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1186
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1187 dev_err(&pf->pdev->dev,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1188 "VF %d failed to set multicast promiscuous mode err %s aq_err %s\n",
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1189 vf->vf_id,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1190 i40e_stat_str(&pf->hw, aq_ret),
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1191 i40e_aq_str(&pf->hw, aq_err));
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1192
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1193 return aq_ret;
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1194 }
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1195
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1196 aq_ret = i40e_aq_set_vsi_unicast_promiscuous(hw, seid,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1197 unicast_enable,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1198 NULL, true);
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1199
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1200 if (aq_ret) {
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1201 int aq_err = pf->hw.aq.asq_last_status;
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1202
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1203 dev_err(&pf->pdev->dev,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1204 "VF %d failed to set unicast promiscuous mode err %s aq_err %s\n",
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1205 vf->vf_id,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1206 i40e_stat_str(&pf->hw, aq_ret),
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1207 i40e_aq_str(&pf->hw, aq_err));
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1208 }
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1209
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1210 return aq_ret;
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1211 }
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1212
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1213 for (i = 0; i < num_vlans; i++) {
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1214 aq_ret = i40e_aq_set_vsi_mc_promisc_on_vlan(hw, seid,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1215 multi_enable,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1216 vl[i], NULL);
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1217 if (aq_ret) {
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1218 int aq_err = pf->hw.aq.asq_last_status;
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1219
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1220 dev_err(&pf->pdev->dev,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1221 "VF %d failed to set multicast promiscuous mode err %s aq_err %s\n",
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1222 vf->vf_id,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1223 i40e_stat_str(&pf->hw, aq_ret),
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1224 i40e_aq_str(&pf->hw, aq_err));
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1225 }
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1226
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1227 aq_ret = i40e_aq_set_vsi_uc_promisc_on_vlan(hw, seid,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1228 unicast_enable,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1229 vl[i], NULL);
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1230 if (aq_ret) {
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1231 int aq_err = pf->hw.aq.asq_last_status;
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1232
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1233 dev_err(&pf->pdev->dev,
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1234 "VF %d failed to set unicast promiscuous mode err %s aq_err %s\n",
37d318d7805f25 Aleksandr Loktionov 2020-05-29 1235 vf->vf_id,
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1236 i40e_stat_str(&pf->hw, aq_ret),
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1237 i40e_aq_str(&pf->hw, aq_err));
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1238 }
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1239 }
0ce5233e6c2afe Mariusz Stachura 2018-08-20 @1240 return aq_ret;
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1241 }
0ce5233e6c2afe Mariusz Stachura 2018-08-20 1242
:::::: The code at line 1240 was first introduced by commit
:::::: 0ce5233e6c2afeb39b9631961978a993a6d4e500 i40e: Unset promiscuous settings on VF reset
:::::: TO: Mariusz Stachura <mariusz.stachura@...el.com>
:::::: CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (30858 bytes)
Powered by blists - more mailing lists