lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Aug 2020 21:12:10 -0600 From: David Ahern <dsahern@...il.com> To: Namhyung Kim <namhyung@...nel.org>, David Ahern <dsahern@...nel.org> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, linux-kernel <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...nel.org> Subject: Re: [PATCH 2/2] perf sched timehist: Fix use of CPU list with summary option On 8/11/20 12:42 AM, Namhyung Kim wrote: >> @@ -2575,7 +2575,8 @@ static int timehist_sched_change_event(struct perf_tool *tool, >> } >> >> if (!sched->idle_hist || thread->tid == 0) { >> - timehist_update_runtime_stats(tr, t, tprev); >> + if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) >> + timehist_update_runtime_stats(tr, t, tprev); >> >> if (sched->idle_hist) { >> struct idle_thread_runtime *itr = (void *)tr; >> @@ -2848,6 +2849,9 @@ static void timehist_print_summary(struct perf_sched *sched, >> >> printf("\nIdle stats:\n"); >> for (i = 0; i < idle_max_cpu; ++i) { >> + if (!test_bit(i, cpu_bitmap)) > > Shouldn't it check cpu_list as well? > oh, right. will fix.
Powered by blists - more mailing lists