linux-kernel - fs/btrfs/volumes.h:206 btrfs_device_set_total_bytes() warn: statement has no effect 31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202008131425.ghmkxzwl%lkp@intel.com>
Date:   Thu, 13 Aug 2020 14:46:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Ahmed S. Darwish" <a.darwish@...utronix.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>
Subject: fs/btrfs/volumes.h:206 btrfs_device_set_total_bytes() warn:
 statement has no effect 31

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   dc06fe51d26efc100ac74121607c01a454867c91
commit: 55f3560df975f557c48aa6afc636808f31ecb87a seqlock: Extend seqcount API with associated locks
date:   2 weeks ago
config: parisc-randconfig-m031-20200811 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
fs/btrfs/volumes.h:206 btrfs_device_set_total_bytes() warn: statement has no effect 31
fs/btrfs/volumes.h:207 btrfs_device_set_disk_total_bytes() warn: statement has no effect 31
fs/btrfs/volumes.h:208 btrfs_device_set_bytes_used() warn: statement has no effect 31
fs/btrfs/volumes.h:206 btrfs_device_set_total_bytes() warn: statement has no effect 31
fs/btrfs/volumes.h:207 btrfs_device_set_disk_total_bytes() warn: statement has no effect 31
fs/btrfs/volumes.h:208 btrfs_device_set_bytes_used() warn: statement has no effect 31
block/partitions/../blk.h:424 part_nr_sects_write() warn: statement has no effect 31

Old smatch warnings:
fs/btrfs/volumes.c:1091 btrfs_free_extra_devids() error: we previously assumed 'latest_dev' could be null (see line 1046)
fs/btrfs/volumes.c:6008 __btrfs_map_block() error: 'em' dereferencing possible ERR_PTR()
fs/btrfs/volumes.c:6827 read_one_dev() error: potential null dereference 'device'.  (add_missing_dev returns null)
block/partitions/core.c:172 check_partition() warn: passing zero to 'ERR_PTR'
include/linux/fs.h:888 i_size_write() warn: statement has no effect 31

vim +206 fs/btrfs/volumes.h

7cc8e58d53cd22 Miao Xie 2014-09-03  205  
7cc8e58d53cd22 Miao Xie 2014-09-03 @206  BTRFS_DEVICE_GETSET_FUNCS(total_bytes);
7cc8e58d53cd22 Miao Xie 2014-09-03 @207  BTRFS_DEVICE_GETSET_FUNCS(disk_total_bytes);
7cc8e58d53cd22 Miao Xie 2014-09-03 @208  BTRFS_DEVICE_GETSET_FUNCS(bytes_used);
7cc8e58d53cd22 Miao Xie 2014-09-03  209  

:::::: The code at line 206 was first introduced by commit
:::::: 7cc8e58d53cd2295c3c1cee7b503bd1790ea4486 Btrfs: fix unprotected device's variants on 32bits machine

:::::: TO: Miao Xie <miaox@...fujitsu.com>
:::::: CC: Chris Mason <clm@...com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30888 bytes)