lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Aug 2020 10:03:18 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Tian Tao <tiantao6@...ilicon.com>, airlied@...ux.ie,
        daniel@...ll.ch, kraxel@...hat.com, alexander.deucher@....com,
        tglx@...utronix.de, dri-devel@...ts.freedesktop.org,
        xinliang.liu@...aro.org, linux-kernel@...r.kernel.org
Cc:     linuxarm@...wei.com
Subject: Re: [PATCH] drm/hisilicon: Fix build error of no type of module_init

Hi

Am 13.08.20 um 05:39 schrieb Tian Tao:
> Add missing include to fix build error:
> hibmc_drm_drv.c:385:1: warning: data definition has no type or storage
> class [enabled by default]
> hibmc_drm_drv.c:385:1: error: type defaults to ‘int’ in declaration
> of ‘module_init’ [-Werror=implicit-int]
> hibmc_drm_drv.c:385:1: warning: parameter names (without types) in function
> of ‘module_exit’ [-Werror=implicit-int]
> hibmc_drm_drv.c:385:292:1: warning: parameter names (without types) in
> function declaration [enabled by default]
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> Reported-by: kernel test robot <lkp@...el.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

I pushed the patch to drm-misc-next, but forgot to add my R-b tag. If
anyone complains, it's my fault.

Best regards
Thomas

> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index 1ae360d..2b4f821 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -11,6 +11,7 @@
>   *	Jianhua Li <lijianhua@...wei.com>
>   */
>  
> +#include <linux/module.h>
>  #include <linux/pci.h>
>  
>  #include <drm/drm_atomic_helper.h>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "signature.asc" of type "application/pgp-signature" (517 bytes)

Powered by blists - more mailing lists