linux-kernel - Re: [PATCH] [v2] ALSA: echoaudio: Fix potential Oops in snd_echo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h364qx5me.wl-tiwai@suse.de>
Date:   Thu, 13 Aug 2020 11:22:17 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Mark Hills <mark@...x.org>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Giuliano Pochini <pochini@...ny.it>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] ALSA: echoaudio: Fix potential Oops in snd_echo_resume()

On Thu, 13 Aug 2020 09:46:30 +0200,
Dinghao Liu wrote:
> 
> Freeing chip on error may lead to an Oops at the next time
> the system goes to resume. Fix this by removing all
> snd_echo_free() calls on error.
> 
> Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Applied, thanks.


Takashi