linux-kernel - Re: [RFC PATCH] mm : using bdi->ra_pages instead of ra->ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200813111924.GE17456@casper.infradead.org>
Date:   Thu, 13 Aug 2020 12:19:24 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Zhaoyang Huang <huangzhaoyang@...il.com>
Cc:     Roman Gushchin <klamm@...dex-team.ru>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Zhaoyang Huang <zhaoyang.huang@...soc.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] mm : using bdi->ra_pages instead of ra->ra_pages
 within readahead

On Thu, Aug 13, 2020 at 04:11:22PM +0800, Zhaoyang Huang wrote:
> file->f_ra->ra_pages will remain the initialized value since it opend, which may
> be NOT equal to bdi->ra_pages as the latter one is updated somehow(etc,
> echo xxx > /sys/block/dm/queue/read_ahead_kb).So having readahead use
> bdi->ra_pages.

But now it ignores the work done by shrink_readahead_size_eio()
and fadvise(POSIX_FADV_SEQUENTIAL).  And you missed the use of ra_size
on the previous line, miscalculating ra->start.

> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
> ---
>  mm/filemap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index d78f577..259dcfd 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2499,8 +2499,8 @@ static struct file *do_sync_mmap_readahead(struct vm_fault *vmf)
>  	 */
>  	fpin = maybe_unlock_mmap_for_io(vmf, fpin);
>  	ra->start = max_t(long, 0, offset - ra->ra_pages / 2);
> -	ra->size = ra->ra_pages;
> -	ra->async_size = ra->ra_pages / 4;
> +	ra->size = inode_to_bdi(mapping->host)->ra_pages;
> +	ra->async_size = ra->size / 4;
>  	ra_submit(ra, mapping, file);
>  	return fpin;
>  }
> -- 
> 1.9.1
> 
>