linux-kernel - Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Aug 2020 10:05:23 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     Will Deacon <will@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Leo Yan <leo.yan@...aro.org>, Ian Rogers <irogers@...gle.com>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Kemeng Shi <shikemeng@...wei.com>,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Igor Lubashev <ilubashe@...mai.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        James Clark <james.clark@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and
 arm-spe's timestamp

Em Thu, Aug 13, 2020 at 01:08:02PM +0100, John Garry escreveu:
> On 13/08/2020 12:18, Will Deacon wrote:
> > [ Adding John, as I only just realised he wasn't on CC and we were talking
> >    about him! ]
> > 
> > On Thu, Aug 13, 2020 at 10:59:01AM +0100, Will Deacon wrote:
> > > On Wed, Aug 12, 2020 at 03:53:34PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Wed, Aug 12, 2020 at 10:06:53AM -0600, Mathieu Poirier escreveu:
> > > > > The ARM SPE perf tools code is orphan and I don't have the cycles to
> > > > > pick it up.  Leo has spent a lot of time in that code and as such I
> > > > > suggest that he starts maintaining it, probably following the same
> > > > > kind of arrangement you and I have for coresight.
> > > > 
> > > > Thats ok with me, I think we should reflect that on the MAINTAINERS
> > > > file, right?
> > > > 
> > > > We have this already:
> > > > 
> > > > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > > > R:      John Garry <john.garry@...wei.com>
> > > > R:      Will Deacon <will@...nel.org>
> > > > L:      linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
> > > > S:      Supported
> > > > F:      tools/perf/pmu-events/arch/arm64/
> > > > 
> > > > I think we should have entries for CoreSight and ARM SPE, one listing
> > > > you as the maintainer and the other listing Leo, right?
> > > 
> > > Fine by me. I'll continue to maintain the in-kernel SPE driver, but I'd love
> > > to see somebody step up to looking after the userspace code. It's seriously
> > > unloved on arm64 :(
> > > 
> > > I'd even be happy to see one or two M: entries added for
> > > tools/perf/pmu-events/arch/arm64/. I realistically don't have the time to
> > > take that on, but I'd be thrilled if any/all of John, Mathieu and Leo were
> > > to be listed there if they are willing to do so and can spare the time to
> > > look after it. Even just silly things like making sure the thing
> > > cross-compiles have been broken in the recent past, so it's not necessarily
> > > about handling huge amounts of incoming patches.
> > > 
> > > In other words, rather than slice up the arm64 parts of the perf tool, I'd
> > > argue in favour of a joint maintainership model for all the arm64 bits, if
> > > we have a few willing volunteers.
> 
> Right, it makes sense not to chop up too much, so happy to see "PERFORMANCE
> EVENTS SUBSYSTEM ARM64 PMU EVENTS" expanded in terms of scope and
> membership.

Discuss this as long as you need and then send me a patch for the
MAINTAINERS file with your conclusion.

Great to see this happening,

- Arnaldo