linux-kernel - Re: [PATCH linux-5.2.y-rt only] hrtimer: correct the logic for grab expiry lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05700b0e-1edf-ab5c-ea81-4d4f8f2c20b6@windriver.com>
Date:   Thu, 13 Aug 2020 09:57:19 +0800
From:   Zhantao Tang <zhantao.tang@...driver.com>
To:     Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        linux-kernel@...r.kernel.org
Cc:     bigeasy@...utronix.de, tglx@...utronix.de, rostedt@...dmis.org,
        linux-rt-users@...r.kernel.org
Subject: Re: [PATCH linux-5.2.y-rt only] hrtimer: correct the logic for grab
 expiry lock


在 2020/8/12 下午7:45, Rasmus Villemoes 写道:
> On 12/08/2020 12.50, zhantao.tang@...driver.com wrote:
>> From: Zhantao Tang <zhantao.tang@...driver.com>
>>
>> In commit: 47b6de0b7f22 ("hrtimer: Add a missing bracket and hide `migration_base' on !SMP")
>> a inline function is_migration_base() is introduced. But
>> the logic of the hrtimer_grab_expiry_lock was changed.
>>
>> This patch is to correct it.
>>
> Yup, same patch sent back in April, which also had a fixes tag for 5.2.
>
> https://lore.kernel.org/lkml/20200428144026.5882-1-rasmus.villemoes@prevas.dk/
>
> It got picked up for 4.19-rt, dunno why it wasn't for 5.2-rt.

Yes， currently 5.2 rt kernel not fix the issue.

And I checked the 4.19 rt kernel, but  did not find the implementation 
of hrtimer_grab_expiry_lock().

It used hrtimer_wait_for_timer() and the logic is OK.


Thanks,

Zhantao

>
> Rasmus