linux-kernel - Re: [PATCH] sched: print fields name when do sched_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200813191125.GA2337490@gmail.com>
Date:   Thu, 13 Aug 2020 21:11:25 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Libing Zhou <libing.zhou@...ia-sbell.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, linux-kernel@...r.kernel.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de
Subject: Re: [PATCH] sched: print fields name when do sched_show_task


* Libing Zhou <libing.zhou@...ia-sbell.com> wrote:

> Current sysrq(t) output task fields name are not aligned with
> actual task fields value, e.g.:
> 
>         kernel: sysrq: SysRq : Show State
>         kernel:  task                        PC stack   pid father
>         kernel: systemd         S12456     1      0 0x00000000
>         kernel: Call Trace:
>         kernel: ? __schedule+0x240/0x740
> 
> To make it more readable, print fields name together with task fields
> value in same line, remove separate fields name print.

Makes sense in principle, but could you please quote the new format as 
well in the changelog, not just the old format? Makes it much easier 
to compare.

Thanks,

	Ingo