linux-kernel - [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20952e3e-6b06-11e4-aff7-07dfbdc5ee18@infradead.org>
Date:   Thu, 13 Aug 2020 12:58:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, jsbarnes@...gle.com
Cc:     Arjan van de Ven <arjan@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>
Subject: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not
 enabled

From: Randy Dunlap <rdunlap@...radead.org>

Fix build error when CONFIG_ACPI is not set/enabled by adding
the header file <asm/acpi.h> which contains a stub for the function
in the build error.

../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
  acpi_noirq_set();

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc: Len Brown <lenb@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Jesse Barnes <jsbarnes@...gle.com>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: linux-pci@...r.kernel.org
---
Found in linux-next, but applies to/exists in mainline also.

Alternative.1: X86_INTEL_MID depends on ACPI
Alternative.2: drop X86_INTEL_MID support

 arch/x86/pci/intel_mid_pci.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20200813.orig/arch/x86/pci/intel_mid_pci.c
+++ linux-next-20200813/arch/x86/pci/intel_mid_pci.c
@@ -33,6 +33,7 @@
 #include <asm/hw_irq.h>
 #include <asm/io_apic.h>
 #include <asm/intel-mid.h>
+#include <asm/acpi.h>
 
 #define PCIE_CAP_OFFSET	0x100