linux-kernel - Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be055bef-e731-7242-78ca-e1844389c791@loongson.cn>
Date:   Fri, 14 Aug 2020 15:31:19 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Huacai Chen <chenhc@...ote.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in
 loongson3_defconfig to fix build warning

On 08/14/2020 02:53 PM, Thomas Bogendoerfer wrote:
> On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
>> Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
> I'm not so sure whether this warrants a fixes tag.

I use git bisect to find it is the first bad commit. Please let me know
if it is not necessary and then I will remove the Fixes tag.

>
>>   arch/mips/configs/loongson3_defconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
>> index a65b08d..2b356d9 100644
>> --- a/arch/mips/configs/loongson3_defconfig
>> +++ b/arch/mips/configs/loongson3_defconfig
>> @@ -403,7 +403,7 @@ CONFIG_CRYPTO_TEA=m
>>   CONFIG_CRYPTO_TWOFISH=m
>>   CONFIG_CRYPTO_DEFLATE=m
>>   CONFIG_PRINTK_TIME=y
>> -CONFIG_FRAME_WARN=1024
>> +CONFIG_FRAME_WARN=2048
> what about just dropping it ? Default for 64bit is 2048. Leaving it out
> of the config has the advantage that you will get a change of the default
> for free.

OK, looks good to me, I will send v2.

Thanks,
Tiezhu

>
> Thomas.
>