linux-kernel - Re: [PATCH] nvme-pci: cancel nvme device request before disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814081647.GA10347@lst.de>
Date:   Fri, 14 Aug 2020 10:16:47 +0200
From:   Christoph Hellwig <hch@....de>
To:     Tong Zhang <ztong0001@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
        kbusch@...nel.org, axboe@...com, hch@....de, sagi@...mberg.me
Subject: Re: [PATCH] nvme-pci: cancel nvme device request before disabling

On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote:
>   This patch addresses an irq free warning and null pointer dereference
>   error problem when nvme devices got timeout error during initialization.
>   This problem happens when nvme_timeout() function is called while
>   nvme_reset_work() is still in execution. This patch fixed the problem by
>   setting flag of the problematic request to NVME_REQ_CANCELLED before
>   calling nvme_dev_disable() to make sure __nvme_submit_sync_cmd() returns
>   an error code and let nvme_submit_sync_cmd() fail gracefully.
>   The following is console output.

The commit log looks a little weird due to the extra indentation.

The patch itself looks good, though:

Reviewed-by: Christoph Hellwig <hch@....de>