linux-kernel - Re: [PATCH v2] seqlock: Fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814102035.GA2367157@gmail.com>
Date:   Fri, 14 Aug 2020 12:20:35 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Xingxing Su <suxingxing@...ngson.cn>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] seqlock: Fix build errors


* Peter Zijlstra <peterz@...radead.org> wrote:

> > Signed-off-by: Xingxing Su <suxingxing@...ngson.cn>
> > ---
> >  v2:  update the commit message
> > 
> >  include/linux/seqlock.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> > index 54bc204..4763c13 100644
> > --- a/include/linux/seqlock.h
> > +++ b/include/linux/seqlock.h
> > @@ -17,6 +17,7 @@
> >  #include <linux/lockdep.h>
> >  #include <linux/compiler.h>
> >  #include <linux/kcsan-checks.h>
> > +#include <linux/smp.h>
> >  #include <asm/processor.h>
> 
> Wrong place, it's lockdep_assert_preemption_disabled() that requires
> asm/percpu.h, and thus lockdep.h should include linux/smp. before
> asm/percpu.h

It already does that upstream:

 #ifndef __LINUX_LOCKDEP_H
 #define __LINUX_LOCKDEP_H

 #include <linux/lockdep_types.h>
 #include <linux/smp.h>
 #include <asm/percpu.h>

So it would be interesting to know what kernel version the build error 
occurs on.

Thanks,

	Ingo