linux-kernel - Re: [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814113927.GA15832@Red>
Date:   Fri, 14 Aug 2020 13:39:27 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Stephen Kitt <steve@....org>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe

On Thu, Aug 13, 2020 at 06:11:29PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
> 
> Signed-off-by: Stephen Kitt <steve@....org>
> ---
>  drivers/hwmon/adm1029.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
> index f7752a5bef31..50b1df7b008c 100644
> --- a/drivers/hwmon/adm1029.c
> +++ b/drivers/hwmon/adm1029.c
> @@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
>  	return 1;
>  }
>  
> -static int adm1029_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adm1029_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct adm1029_data *data;
> @@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
>  	.driver = {
>  		.name = "adm1029",
>  	},
> -	.probe		= adm1029_probe,
> +	.probe_new	= adm1029_probe,
>  	.id_table	= adm1029_id,
>  	.detect		= adm1029_detect,
>  	.address_list	= normal_i2c,
> -- 
> 2.25.4
> 
Hello

Acked-by: Corentin LABBE <clabbe.montjoie@...il.com>

But please give me a few day to test it.