linux-kernel - Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814151358.GA256451@roeck-us.net>
Date:   Fri, 14 Aug 2020 08:13:58 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stephen Kitt <steve@....org>
Cc:     Beniamin Bia <beniamin.bia@...log.com>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

On Thu, Aug 13, 2020 at 06:09:58PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
> 
> Signed-off-by: Stephen Kitt <steve@....org>

I'll apply the entire series, but please don't use entire path names
as tag in the future but follow bubsystem rules.

Thanks,
Guenter

> ---
>  drivers/hwmon/adm1177.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/adm1177.c b/drivers/hwmon/adm1177.c
> index d314223a404a..6e8bb661894b 100644
> --- a/drivers/hwmon/adm1177.c
> +++ b/drivers/hwmon/adm1177.c
> @@ -196,8 +196,7 @@ static void adm1177_remove(void *data)
>  	regulator_disable(st->reg);
>  }
>  
> -static int adm1177_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adm1177_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct device *hwmon_dev;
> @@ -277,7 +276,7 @@ static struct i2c_driver adm1177_driver = {
>  		.name = "adm1177",
>  		.of_match_table = adm1177_dt_ids,
>  	},
> -	.probe = adm1177_probe,
> +	.probe_new = adm1177_probe,
>  	.id_table = adm1177_id,
>  };
>  module_i2c_driver(adm1177_driver);