linux-kernel - Re: [PATCH] nvme-pci: Use u32 for nvme_dev.q_depth and nvme_queue.q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814154934.GB3772144@dhcp-10-100-145-180.wdl.wdc.com>
Date:   Fri, 14 Aug 2020 08:49:34 -0700
From:   Keith Busch <kbusch@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     axboe@...com, hch@....de, sagi@...mberg.me,
        chaitanya.kulkarni@....com, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: Use u32 for nvme_dev.q_depth and
 nvme_queue.q_depth

On Fri, Aug 14, 2020 at 11:34:25PM +0800, John Garry wrote:
> Fix by making onto a u32.
> 
> Also use u32 for nvme_dev.q_depth, as we assign this value from
> nvme_dev.q_depth, and nvme_dev.q_depth will possibly hold 65536 - this
> avoids the same crash as above.
> 
> Fixes: 61f3b8963097 ("nvme-pci: use unsigned for io queue depth")
> Signed-off-by: John Garry <john.garry@...wei.com>

Looks good to me.

Reviewed-by: Keith Busch <kbusch@...nel.org>