linux-kernel - Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200814163831.GN4354@dell>
Date:   Fri, 14 Aug 2020 17:38:31 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        Benjamin Reed <breed@...rs.sourceforge.net>,
        Javier Achirica <achirica@...rs.sourceforge.net>,
        Jean Tourrilhes <jt@....hp.com>,
        Fabrice Bellet <fabrice@...let.info>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding
 style issues

On Fri, 14 Aug 2020, Kalle Valo wrote:

> Lee Jones <lee.jones@...aro.org> writes:
> 
> >  - Ensure spaces appear after {for, if, while, etc}
> >  - Ensure spaces to not appear after '('
> >  - Ensure spaces to not appear before ')'
> >  - Ensure spaces appear between ')' and '{'
> >  - Ensure spaces appear after ','
> >  - Ensure spaces do not appear before ','
> >  - Ensure spaces appear either side of '='
> >  - Ensure '{'s which open functions are on a new line
> >  - Remove trailing whitespace
> >
> > There are still a whole host of issues with this file, but this
> > patch certainly breaks the back of them.
> >
> > Cc: Kalle Valo <kvalo@...eaurora.org>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: Benjamin Reed <breed@...rs.sourceforge.net>
> > Cc: Javier Achirica <achirica@...rs.sourceforge.net>
> > Cc: Jean Tourrilhes <jt@....hp.com>
> > Cc: Fabrice Bellet <fabrice@...let.info>
> > Cc: linux-wireless@...r.kernel.org
> > Cc: netdev@...r.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  drivers/net/wireless/cisco/airo.c | 897 ++++++++++++++++--------------
> >  1 file changed, 467 insertions(+), 430 deletions(-)
> 
> This is a driver for ancient hardware, I'm not sure if it's worth trying
> to fix any style issues. Is anyone even using it? Should we instead just
> remove the driver?

Sounds like a reasonable solution to me.

I'm also happy to do it, if there are no objections.

As it stands, it's polluting the code-base and the build-log, so
something should be done.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog