linux-kernel - Re: [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Aug 2020 22:17:25 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zejiang Tang <tangzejiang@...ngson.cn>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: ftrace: Remove redundant #ifdef
 CONFIG_DYNAMIC_FTRAC

On Fri, 14 Aug 2020 10:08:15 +0800
Zejiang Tang <tangzejiang@...ngson.cn> wrote:

> There exists redundant #ifdef CONFIG_DYNAMIC_FTRAC in ftrace.c, remove it.
> 
> Signed-off-by: Zejiang Tang <tangzejiang@...ngson.cn>

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> ---
>  arch/mips/kernel/ftrace.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
> index 2625232..f57e68f 100644
> --- a/arch/mips/kernel/ftrace.c
> +++ b/arch/mips/kernel/ftrace.c
> @@ -37,10 +37,6 @@ void arch_ftrace_update_code(int command)
>  	ftrace_modify_all_code(command);
>  }
>  
> -#endif
> -
> -#ifdef CONFIG_DYNAMIC_FTRACE
> -
>  #define JAL 0x0c000000		/* jump & link: ip --> ra, jump to target */
>  #define ADDR_MASK 0x03ffffff	/*  op_code|addr : 31...26|25 ....0 */
>  #define JUMP_RANGE_MASK ((1UL << 28) - 1)