[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <324d61b6-fc26-03ea-f8af-ff74a9767da2@linaro.org>
Date: Fri, 14 Aug 2020 20:12:09 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Tanmay Shah <tanmay@...eaurora.org>, swboyd@...omium.org,
devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
dri-devel@...ts.freedesktop.org, robdclark@...il.com
Cc: linux-kernel@...r.kernel.org, freedreno@...ts.freedesktop.org,
seanpaul@...omium.org, daniel@...ll.ch, airlied@...ux.ie,
aravindh@...eaurora.org, abhinavk@...eaurora.org,
khsieh@...eaurora.org, Chandan Uddaraju <chandanu@...eaurora.org>,
Vara Reddy <varar@...eaurora.org>,
Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v10 2/5] drm/msm/dp: add displayPort driver support
Hello,
On 12/08/2020 07:42, Tanmay Shah wrote:
> From: Chandan Uddaraju <chandanu@...eaurora.org>
[skipped]
> + } else if ((dp_parser_check_prefix("ctrl", clk_name) ||
> + dp_parser_check_prefix("stream", clk_name)) &&
> + ctrl_clk_index < ctrl_clk_count) {
> + struct dss_clk *clk =
> + &ctrl_power->clk_config[ctrl_clk_index];
> + strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name));
> + ctrl_clk_index++;
> +
> + if (!strncmp(clk_name, "ctrl_link",
> + strlen("ctrl_link")) ||
> + !strncmp(clk_name, "stream_pixel",
> + strlen("ctrl_pixel")))
This should be "stream_pixel", I believe. I don't like macros, but most
probably it would help here. Also function/brace alignment could be
better (sorry, it really hides the issue here).
> + clk->type = DSS_CLK_PCLK;
> + else
> + clk->type = DSS_CLK_AHB;
> + }
> + }
--
With best wishes
Dmitry
Powered by blists - more mailing lists