lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 14 Aug 2020 19:14:31 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] genksyms: keywords: Use __restrict not _restrict

On Fri, Aug 14, 2020 at 6:38 PM Joe Perches <joe@...ches.com> wrote:
>
> Use the proper form of the RESTRICT keyword.
>
> Quote the comments properly too.
>
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Nick Desaulniers <ndesaulniers@...gle.com>

(Surprised what looked to me like a typo compiled).  Would a
checkpatch warning be helpful, too? What's KAO? Urban dictionary has
no entry. :^P

> ---
>  scripts/genksyms/keywords.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/genksyms/keywords.c b/scripts/genksyms/keywords.c
> index 7a85c4e21175..057c6cabad1d 100644
> --- a/scripts/genksyms/keywords.c
> +++ b/scripts/genksyms/keywords.c
> @@ -25,9 +25,9 @@ static struct resword {
>         { "__int128_t", BUILTIN_INT_KEYW },
>         { "__uint128_t", BUILTIN_INT_KEYW },
>
> -       // According to rth, c99 defines "_Bool", __restrict", __restrict__", "restrict".  KAO
> +       // According to rth, c99 defines "_Bool", "__restrict", "__restrict__", "restrict".  KAO
>         { "_Bool", BOOL_KEYW },
> -       { "_restrict", RESTRICT_KEYW },
> +       { "__restrict", RESTRICT_KEYW },
>         { "__restrict__", RESTRICT_KEYW },
>         { "restrict", RESTRICT_KEYW },
>         { "asm", ASM_KEYW },
>


-- 
Thanks,
~Nick Desaulniers

Powered by blists - more mailing lists